[dashboard] Fix bottom page margins for Prebuilds, Repositories and Insights #20455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I forgor initially 💀
geropl
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pages right now did not properly keep their distance from the end of the viewport, making the last element hard to reach on mobile, unreadable and aesthetically displeasing.
Related Issue(s)
Fixes #
How to test
I tested these changes in a preview environment for another PR (see screenshots). Feel free to trigger a preview env for this one, but you'll also have to fill up the page with entities (such as prebuilds, repos or workspaces for insights) to observe the fixed margins.
/hold